Open
Conversation
…com/Accessible-Routes/Webb-App into 17-make-the-website-mobile-friendly
…com/Accessible-Routes/Webb-App into 17-make-the-website-mobile-friendly
| const BuildingDropdown = ({ place_holder_text, building_options, setSelectedBuilding }) => { | ||
| // component for allowing a user to select a building from building options | ||
|
|
||
| const handleChange = (selectedOption) => { |
Contributor
There was a problem hiding this comment.
nit: this function name should be changed to be more descriptive/less general.
| const [displayingRoute, setDisplayingRoute] = useState(false); | ||
| const [foundRoute, setFoundRoute] = useState(false); | ||
|
|
||
| const [toggle, setToggle] = useState(false); |
Contributor
There was a problem hiding this comment.
nit: this hook's name should be updated to be more descriptive of what it's toggling
| onChange={handleChange} | ||
| options={building_options} /> | ||
| options={building_options} | ||
| styles={{ |
Contributor
There was a problem hiding this comment.
Microsoft edge has a 3d view tool in it's developer tools that may be helpful in viewing/updating your zIndex changes. I recommend looking for other approaches for setting the Zindex dynamically/setting these values to more "reasonable" values.
MattLMerritt
approved these changes
Apr 14, 2024
Contributor
MattLMerritt
left a comment
MattLMerritt
left a comment
There was a problem hiding this comment.
Incredible work! I've left a few nits related to good practices, but it LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Matt,
If you have time/energy, are you willing to review this pull request? This pull request is relatively big. This is a very new experience for me and Ritika and we were wondering if you would give us lots of advice? We were not familiar with best practices and design so please give whatever feedback.